Fix -Wmissing-prototypes warning on Clang#1863
Merged
Merged
Conversation
Member
|
MSVC doesn't like it: |
The -Wmissing-prototypes Clang warning (or -Wmissing-declarations on GCC) is very useful to avoid accidents where a function definition in a source file doesn't match the corresponding declaration in a header file, as it would warn already during compilation and not much later during link time. Unfortunately this means that exported functions defined only in the source file (usually the ones annotated with `extern "C"`) will cause this warning to be emitted too (on Clang, GCC has a slightly different behavior with -Wmissing-declarations and doesn't warn here). This fixes the warning by providing a declaration right before the definition.
eb0ac8d to
fd5eda3
Compare
Member
|
Merged, thanks! |
Contributor
Author
|
Thank you as well, and apologies for forgetting to ensure AppVeyor passes as well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #1852 this is just a minor change with minimal impact :)
The
-Wmissing-prototypeswarning on Clang (or-Wmissing-declarationson GCC) is very useful to avoid accidents where a function definition in a source file doesn't match the corresponding declaration in a header file, as it would warn already during compilation and not fail much later during link time.Unfortunately this means that exported functions defined only in the source file (usually the ones annotated with
extern "C") will cause this warning to be emitted too (on Clang, GCC has a slightly different behavior with-Wmissing-declarationsand doesn't warn here). For example:This fixes the warning by providing a matching declaration right before the definition, both for the Python 3 and Python 2 variant.